Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid direct URL construction and URL equality checks #29486

Closed
jhoeller opened this issue Nov 14, 2022 · 0 comments
Closed

Avoid direct URL construction and URL equality checks #29486

jhoeller opened this issue Nov 14, 2022 · 0 comments
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@jhoeller
Copy link
Contributor

As a first step towards #29481, driven by the deprecation of the java.net.URL constructors in JDK 20, we can factor out all URL construction to toURL methods in ResourceUtils, centralizing the use of java.net.URL constructors and therefore also their possible replacement in the future.

Also, UrlResource traditionally uses equality on a cleaned URL instance for comparisons. This can be replaced with a check on a cleaned URL String, sourced from either a URI or a URL instance.

@jhoeller jhoeller added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Nov 14, 2022
@jhoeller jhoeller added this to the 6.0.0 milestone Nov 14, 2022
@jhoeller jhoeller self-assigned this Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant