Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce support for Jakarta WebSocket 2.1 #29436

Closed
jhoeller opened this issue Nov 5, 2022 · 0 comments
Closed

Introduce support for Jakarta WebSocket 2.1 #29436

jhoeller opened this issue Nov 5, 2022 · 0 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
6.0.0-RC4

Comments

@jhoeller
Copy link
Contributor

jhoeller commented Nov 5, 2022

Related to #29434, the Jakarta WebSocket API 2.1 introduces a standard mechanism for performing a WebSocket protocol upgrade. While we can use that upgradeHttpToWebSocket method on Tomcat's implementation in TomcatRequestUpgradeStrategy (as per #29434 for compatibility with Tomcat 10.0), we can also introduce a new StandardWebSocketUpgradeStrategy which can use the upgradeHttpToWebSocket method on the Jakarta WebSocket 2.1 ServerContainer interface - and be chosen in AbstractHandshakeHandler when no specific server API has been discovered.
@jhoeller jhoeller added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Nov 5, 2022
@jhoeller jhoeller added this to the 6.0.0-RC4 milestone Nov 5, 2022
@jhoeller jhoeller self-assigned this Nov 5, 2022
@jhoeller jhoeller changed the title Introduce support for Jakarta WebSocket API 2.1 Introduce support for Jakarta WebSocket 2.1 Nov 6, 2022
jhoeller added a commit that referenced this issue Nov 7, 2022
@jhoeller
Reuse StandardWebSocketUpgradeStrategy as a base class for Tomcat etc
a2ac764 
Includes non-reflective instantiation of well-known strategy classes.

See gh-29436
@marcusdacoregio marcusdacoregio mentioned this issue Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC4
Development

No branches or pull requests
1 participant
@jhoeller