Fix and reenable flaky ReactorNetty2StompBrokerRelayIntegrationTests #29287
Labels
Milestone
Comments
sbrannen
added
in: messaging
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this issue
Oct 8, 2022
sbrannen
changed the title
rstoyanchev
added a commit
that referenced
this issue
Nov 22, 2022
To see if it still fails on the CI server as it doesn't fail locally for me, and if it does to get details to investigate. See gh-29287
rstoyanchev
added a commit
that referenced
this issue
Nov 22, 2022
rstoyanchev
added a commit
that referenced
this issue
Nov 23, 2022
sdeleuze
added a commit
to sdeleuze/spring-framework
that referenced
this issue
May 4, 2023
rstoyanchev
added a commit
that referenced
this issue
May 10, 2023
When ReactorNetty2StompBrokerRelayIntegrationTests fail, typically there are multiple exceptions "Connection refused: /127.0.0.1:61613" that appear after we've conneted, sent CONNECT, and expecting CONNECTED, but that does not come within the 10 second timeout. 61613 is the default port for STOMP. However, in all integration tests we start ActiveMQ with port 0 which results in a random port. Moreover, the stacktrace is for Netty 4 (not 5), and the eventloop thread id's are different than the one where the connection to the correct, random port was established. The suspicion is that these are log messages from MessageBrokerConfigurationTests which focuses on testing configuration but nevertheless as a bean starts and attempts to connect to the default port and fails. Perhaps those attempts to connect on the default port somehow affect the ActiveMQ server, and it stops responding. This change adds a no-op TcpClient in MessageBrokerConfigurationTests to avoid unnecessary attempts to connect that are not needed. See gh-29287
rstoyanchev
added a commit
that referenced
this issue
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The tests in
ReactorNetty2StompBrokerRelayIntegrationTestsfail too frequently and need to be properly addressed.The text was updated successfully, but these errors were encountered: