Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TestCompiler to dedicated package #29175

Closed
philwebb opened this issue Sep 20, 2022 · 2 comments
Closed

Move TestCompiler to dedicated package #29175

philwebb opened this issue Sep 20, 2022 · 2 comments
Assignees
@philwebb
Labels
type: enhancement A general enhancement
Milestone
6.0.0-RC1

Comments

@philwebb
Copy link
Member

TestCompiler should move from org.springframework.aot.test.generate.compile to something more general since it's not really tied to AOT.
@philwebb philwebb self-assigned this Sep 20, 2022
@philwebb philwebb added the type: enhancement A general enhancement label Sep 20, 2022
@philwebb philwebb added this to the 6.0.0-RC1 milestone Sep 20, 2022
@snicoll
Copy link
Member

snicoll commented Sep 20, 2022 •
edited
Loading

Reopening to fix the imports of org.springframework.aot.generate in org.springframework.core.test.tools.

@snicoll snicoll reopened this Sep 20, 2022
@snicoll
Copy link
Member

snicoll commented Sep 20, 2022

Fixed by 4625e92

@snicoll snicoll closed this as completed Sep 20, 2022
snicoll added a commit that referenced this issue Sep 20, 2022
@snicoll
Break dependency between TestCompiler and AOT
4625e92 
This commit improves `TestCompiler` with a `with` function that allows
to customize a test compiler instance. Rather than `TestCompiler`
knowing about `TestGenerationContext`, the latter implements the
function so that it can be passed as is.

See gh-29175
philwebb added a commit that referenced this issue Sep 20, 2022
@philwebb
Refactor GeneratedFilesTestCompilerUtils to CompilerFiles
6802665 
See gh-29175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-RC1
Development

No branches or pull requests
2 participants
@snicoll @philwebb