Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce TestRuntimeHintsRegistrar in the TestContext framework #29069

Closed
sbrannen opened this issue Sep 4, 2022 · 0 comments
Closed

Introduce TestRuntimeHintsRegistrar in the TestContext framework #29069

sbrannen opened this issue Sep 4, 2022 · 0 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.0.0-M6

Comments

@sbrannen
Copy link
Member

sbrannen commented Sep 4, 2022

Although org.springframework.aot.hint.RuntimeHintsRegistrar can be implemented to register general hints that should be applied for all testing infrastructure, certain use cases require access to test classes and the MergedContextConfiguration in order to register appropriate hints.

In light of that, we need to introduce TestRuntimeHintsRegistrar as a companion to RuntimeHintsRegistrar.
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Sep 4, 2022
@sbrannen sbrannen added this to the 6.0.0-M6 milestone Sep 4, 2022
@sbrannen sbrannen self-assigned this Sep 4, 2022
sbrannen added a commit that referenced this issue Sep 4, 2022
@sbrannen
Introduce StandardTestRuntimeHints in the TestContext framework
cbb3015 
This commit introduces StandardTestRuntimeHints and migrates existing
hint registration from TestContextAotGenerator to this new class.

In addition, this commit removes a package cycle between context.aot and
context.web that was introduced in commit dc7c7ac.

See gh-29026, gh-29069
@sbrannen sbrannen mentioned this issue Sep 4, 2022
Closed
jhoeller added a commit that referenced this issue Oct 11, 2022
@jhoeller
Move hints to dedicated top-level package (avoiding aot<->support cycle)
0f8ca80 
See gh-29026, gh-29069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
1 participant
@sbrannen