Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine JacksonModulesRuntimeHints #29001

Closed
sdeleuze opened this issue Aug 23, 2022 · 3 comments
Closed

Refine JacksonModulesRuntimeHints #29001

sdeleuze opened this issue Aug 23, 2022 · 3 comments
Assignees
@sdeleuze
Labels
theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.0.0-M6

Comments

@sdeleuze
Copy link
Contributor

No description provided.

@sdeleuze sdeleuze added type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Aug 23, 2022
@sdeleuze sdeleuze added this to the 6.0.0-M6 milestone Aug 23, 2022
@sdeleuze sdeleuze self-assigned this Aug 23, 2022
@snicoll
Copy link
Member

snicoll commented Aug 23, 2022

Shouldn't the condition be on a Jackson class? Or the module as it's probably optional.

@sdeleuze
Copy link
Contributor Author

Good point, I will update accordingly.

@sdeleuze
Copy link
Contributor Author

In fact, maybe the condition is ok with the builder but we should add a classpath check on the related modules since those are instantiated reflectively.

@sdeleuze sdeleuze reopened this Aug 23, 2022
@sdeleuze sdeleuze changed the title Add missing condition in JacksonModulesRuntimeHints Refine JacksonModulesRuntimeHints Aug 23, 2022
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 23, 2022
@sdeleuze
Polish JacksonModulesRuntimeHints
2f920e8 
Closes spring-projectsgh-29001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
2 participants
@sdeleuze @snicoll