Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for @Cacheable in native-image #28943

Closed
mhalbritter opened this issue Aug 9, 2022 · 1 comment
Closed

Add support for @Cacheable in native-image #28943

mhalbritter opened this issue Aug 9, 2022 · 1 comment
Assignees
@sdeleuze
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing
Milestone
6.0.0-M6

Comments

@mhalbritter
Copy link
Contributor

mhalbritter commented Aug 9, 2022 •
edited
Loading

@Cacheable doesn't work in native-image. There is no exception, the annotated method is called multiple times, while as on the JVM, it's only called once.

You can observe this in https://github.com/spring-projects/spring-aot-smoke-tests/tree/main/cache-caffeine

I guess this is related to the "proxies in native-image" issue.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 9, 2022
@sdeleuze sdeleuze self-assigned this Aug 10, 2022
@sdeleuze sdeleuze added theme: aot An issue related to Ahead-of-time processing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Aug 10, 2022
@sdeleuze sdeleuze added this to the 6.0.0-M6 milestone Aug 10, 2022
@sdeleuze sdeleuze added the in: core Issues in core modules (aop, beans, core, context, expression) label Aug 10, 2022
@sdeleuze
Copy link
Contributor

sdeleuze commented Aug 11, 2022 •
edited
Loading

I think there is no exception because there are missing reflection hints for @Cacheable and related annotated method.

There is also a need for a CacheableBeanRegistrationAotProcessor to register related JDK dynamic proxies when they are used. Class proxies will hopefully be supported via #28115 once integrated in Spring Boot.

sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Aug 17, 2022
@sdeleuze
Register proper caching annotation runtime hints
491b777 
See spring-projectsgh-28943
sdeleuze added a commit to sdeleuze/spring-aot-smoke-tests that referenced this issue Aug 17, 2022
@sdeleuze
Add cache-simple-jdk-proxy example
77236fc 
Related to spring-projects/spring-framework#28943
sdeleuze added a commit to sdeleuze/spring-aot-smoke-tests that referenced this issue Aug 17, 2022
@sdeleuze
Add cache-simple-jdk-proxy example
470d1ba 
Related to spring-projects/spring-framework#28943
@sdeleuze sdeleuze mentioned this issue Aug 17, 2022
Closed
snicoll pushed a commit to spring-projects/spring-aot-smoke-tests that referenced this issue Aug 17, 2022
@sdeleuze @snicoll
Add cache-simple-jdk-proxy example
d4b121a 
Related to spring-projects/spring-framework#28943

See gh-90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdeleuze sdeleuze

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: aot An issue related to Ahead-of-time processing
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
3 participants
@sdeleuze @spring-projects-issues @mhalbritter