Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompileWithTargetClassAccessExtension fails to select overloaded test methods #28901

Closed
sbrannen opened this issue Aug 1, 2022 · 0 comments
Closed

CompileWithTargetClassAccessExtension fails to select overloaded test methods #28901

sbrannen opened this issue Aug 1, 2022 · 0 comments
Assignees
@sbrannen
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Milestone
6.0.0-M6

Comments

@sbrannen
Copy link
Member

sbrannen commented Aug 1, 2022

The method lookup algorithm in CompileWithTargetClassAccessExtension is based solely on the class name and method name. In other words, it omits the parameter list of the method declaration. This results in CompileWithTargetClassAccessExtension selecting the wrong test method if the test class hierarchy declares multiple methods with the same name but different parameter lists.
@sbrannen sbrannen added in: test Issues in the test module type: bug A general bug theme: aot An issue related to Ahead-of-time processing labels Aug 1, 2022
@sbrannen sbrannen added this to the 6.0.0-M6 milestone Aug 1, 2022
@sbrannen sbrannen self-assigned this Aug 1, 2022
sbrannen added a commit that referenced this issue Aug 1, 2022
@sbrannen
Removed unused method parameter
d9bf3e5 
See gh-28901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: bug A general bug
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
1 participant
@sbrannen