Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce TestGenerationContext #28877

Closed
snicoll opened this issue Jul 26, 2022 · 2 comments
Closed

Introduce TestGenerationContext #28877

snicoll opened this issue Jul 26, 2022 · 2 comments
Assignees
@snicoll
Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
6.0.0-M6

Comments

@snicoll
Copy link
Member

snicoll commented Jul 26, 2022

Looking at #28684, it became apparent that Closeable wasn't really an option but that we could make writeGeneratedContent more prominent and let it throws an IOException. This had a knock-off effect on the tests which was easily handled using our internal TestGenerationContext.

This impacts obviously tests outside of the Spring Framework so a public variant of it is needed.
@snicoll snicoll added in: test Issues in the test module type: enhancement A general enhancement labels Jul 26, 2022
@snicoll snicoll added this to the 6.0.0-M6 milestone Jul 26, 2022
@snicoll snicoll self-assigned this Jul 26, 2022
@snicoll snicoll added the theme: aot An issue related to Ahead-of-time processing label Jul 26, 2022
@snicoll snicoll mentioned this issue Jul 26, 2022
Closed
snicoll added a commit to spring-projects/spring-boot that referenced this issue Jul 26, 2022
@snicoll
Adapt to changes in DefaultGenerationContext
193c1d7 
See spring-projects/spring-framework#28877
@sbrannen
Copy link
Member

Reopening to move TestGenerationContext from spring-test to spring-core-test.

@sbrannen sbrannen reopened this Aug 16, 2022
snicoll added a commit that referenced this issue Sep 5, 2022
@snicoll
Relocate TestGenerationContext to spring-core-test
58b0251 
This commit moves the test implementation for GenerationContext in
spring-core-test. This also removes the copy we had in testfixtures

See gh-28877
@snicoll
Copy link
Member Author

snicoll commented Sep 5, 2022

Fixed by 58b0251 which also removes the test fixtures copy!

@snicoll snicoll closed this as completed Sep 5, 2022
snicoll added a commit to spring-projects/spring-boot that referenced this issue Sep 5, 2022
@snicoll
Adapt to recent changes in Spring Framework
e5d0e34 
See spring-projects/spring-framework#29082
See spring-projects/spring-framework#28877
christophstrobl added a commit to spring-projects/spring-data-commons that referenced this issue Sep 6, 2022
@christophstrobl
Follow changes in core framework
918a439 
See spring-projects/spring-framework#29082
See spring-projects/spring-framework#28877
christophstrobl added a commit to spring-projects/spring-data-commons that referenced this issue Sep 6, 2022
@christophstrobl
Update usage of TestGenerationContext.
1ccdac2 
Add required artifact and update package name.

See: spring-projects/spring-framework#28877
christophstrobl added a commit to spring-projects/spring-data-commons that referenced this issue Oct 4, 2022
@christophstrobl
Follow changes in core framework
e32119a 
See spring-projects/spring-framework#29082
See spring-projects/spring-framework#28877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
in: test Issues in the test module theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
2 participants
@sbrannen @snicoll