Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for cyclic annotation parameter types in Kotlin #28618

Closed
poutsma opened this issue Jun 14, 2022 · 1 comment
Closed

Remove support for cyclic annotation parameter types in Kotlin #28618

poutsma opened this issue Jun 14, 2022 · 1 comment
Assignees
@poutsma
Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: kotlin An issue related to Kotlin support type: task A general task
Milestone
6.0.0-M5

Comments

@poutsma
Copy link
Contributor

poutsma commented Jun 14, 2022 •
edited
Loading

#28012 introduced support for cyclic annotation parameter types in Kotlin. However, in Kotlin 1.7 the compiler gives a warning for these cyclic parameters, which will turn into an error in Kotlin 1.9. See KT-47932.

We could theoretically keep supporting cyclic annotation parameters, but by this point it is clear that this feature was never intended to be there. So removal seems better.

Effectively, this would mean reverting 3ec612a and 3188c0f.
@poutsma poutsma added in: core Issues in core modules (aop, beans, core, context, expression) theme: kotlin An issue related to Kotlin support labels Jun 14, 2022
@poutsma poutsma added this to the 6.0.0-M5 milestone Jun 14, 2022
@poutsma poutsma self-assigned this Jun 14, 2022
@poutsma poutsma mentioned this issue Jun 14, 2022
Closed
@poutsma poutsma added the type: task A general task label Jun 14, 2022
@poutsma
Copy link
Contributor Author

poutsma commented Jun 14, 2022

Resolved in bf9f261

@poutsma poutsma closed this as completed Jun 14, 2022
@jhoeller jhoeller mentioned this issue Oct 10, 2023
Closed
sbrannen pushed a commit that referenced this issue Nov 8, 2023
@lorenzsimon @sbrannen
Restore support for recursive annotations in Kotlin
6a7a0bd 
This commit reinstates support for recursive annotations in Kotlin.

See gh-28012
See gh-28618
See gh-31400
Closes gh-31518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: core Issues in core modules (aop, beans, core, context, expression) theme: kotlin An issue related to Kotlin support type: task A general task
Projects
None yet
Milestone
6.0.0-M5
Development

No branches or pull requests
1 participant
@poutsma