Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ByteArrayDecoder in DefaultClientResponse::createException #27666

Closed
poutsma opened this issue Nov 10, 2021 · 2 comments
Closed

Use ByteArrayDecoder in DefaultClientResponse::createException #27666

poutsma opened this issue Nov 10, 2021 · 2 comments
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.3.13

Comments

@poutsma
Copy link
Contributor

poutsma commented Nov 10, 2021

In DefaultClientResponse::createException, instead of "converting" the response body into DataBuffers and turning those in a byte array , we should use the ByteArrayDecoder which does that in a single step.
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Nov 10, 2021
@poutsma poutsma added this to the 5.3.13 milestone Nov 10, 2021
@poutsma poutsma self-assigned this Nov 10, 2021
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x labels Nov 10, 2021
Closed
poutsma added a commit that referenced this issue Nov 10, 2021
@poutsma
Use ByteArrayDecoder in DefaultClientResponse::createException
24ebb5e 
This commit changes DefaultClientResponse::createException to use
the ByteArrayDecoder, instead of converting to DataBuffers and
turning these into a byte array.

Closes gh-27666
@sync-by-unito sync-by-unito bot mentioned this issue Nov 11, 2021
Closed
@KimJejun
Copy link

Hi there.

I have a problem on 5.3.13 version.
Can u check this question?

https://stackoverflow.com/questions/70691486/spring-webclient-getresponsebodyasstring-is-emptyover-spring-5-3-13

@MrJonniK
Copy link

Hi there.

I have a problem on 5.3.13 version. Can u check this question?

https://stackoverflow.com/questions/70691486/spring-webclient-getresponsebodyasstring-is-emptyover-spring-5-3-13

I faced the same problem. I get an empty response body in WebClientResponseException since version 5.3.13

@Gieted Gieted mentioned this issue Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.13
Development

No branches or pull requests
5 participants
@poutsma @rstoyanchev @KimJejun @spring-projects-issues @MrJonniK