Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AspectJ 1.9.8-RC3 #27537

Closed
sbrannen opened this issue Oct 8, 2021 · 3 comments
Closed

Upgrade to AspectJ 1.9.8-RC3 #27537

sbrannen opened this issue Oct 8, 2021 · 3 comments
Assignees
Labels
type: dependency-upgrade A dependency upgrade
Milestone

Comments

@sbrannen
Copy link
Member

sbrannen commented Oct 8, 2021

Overview

AspectJ 1.9.8 RC1 was released today, so we'll start testing against that and upgrade to 1.9.8 GA once it's been released.

Resources

Deliverables

  • Upgrade to AspectJ 1.9.8 GA
  • Add note to reference manual regarding changes to LTW support (see AspectJ 1.9.8 release notes for details)
@sbrannen sbrannen added the type: dependency-upgrade A dependency upgrade label Oct 8, 2021
@sbrannen sbrannen added this to the 6.0 M1 milestone Oct 8, 2021
@sbrannen sbrannen self-assigned this Oct 8, 2021
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Oct 8, 2021
@kriegaex
Copy link
Contributor

kriegaex commented Oct 9, 2021

Thanks for adopting the new AspectJ version so quickly. I am looking forward to your feedback. Not knowing what the minimum Java version is in your build system, please note the following caveat:

  • The Eclipse Java Compiler (ECJ) 3.2.7 supporting Java 17 now needs JDK 11+ as a build environment, because Eclipse migrated the code base to Java 11. Because the AspectJ Compiler (AJC) contained in aspectjtools is an ECJ fork, using a Java-17-enabled AJC version (1.9.8.RC1 and higher) means that you need to run your build on JDK 11+. You can still compile to goals as low as Java 1.3, don't worry. It is only about the build environment. I am not sure if you even use AJC or depend on the AspectJ Tools library anywhere, please check.

  • As for LTW, I just verified that for now, the class files contained in the smaller aspectjweaver agent library still do not contain any Java 11 class files, i.e. LTW should still work on JDK 8 systems.

@sbrannen
Copy link
Member Author

Thanks for adopting the new AspectJ version so quickly. I am looking forward to your feedback.

You're welcome. We're glad to help integration test with the RC before the GA release.

Our build is working fine with the changes in fa3a2dc.

Not knowing what the minimum Java version is in your build system, please note the following caveat:

For Spring Framework 6.0 (main), Java 17 is the baseline for the build and any applications using Spring 6.0.

@jhoeller
Copy link
Contributor

jhoeller commented Dec 14, 2021

I'm about to close this issue with an upgrade to AspectJ 1.9.8 RC3 (for 6.0 M1). We can track the AspectJ 1.9.8 GA upgrade in #27416 then.

@snicoll snicoll changed the title Upgrade to AspectJ 1.9.8 for official Java 17 support Upgrade to AspectJ 1.9.8 Feb 16, 2022
@snicoll snicoll changed the title Upgrade to AspectJ 1.9.8 Upgrade to AspectJ 1.9.8-RC1 Feb 16, 2022
@snicoll snicoll changed the title Upgrade to AspectJ 1.9.8-RC1 Upgrade to AspectJ 1.9.8-RC3 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

No branches or pull requests

3 participants