Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Jetty 10 check in JettyClientHttpResponse #27136

Closed
poutsma opened this issue Jul 6, 2021 · 1 comment
Closed

Improve Jetty 10 check in JettyClientHttpResponse #27136

poutsma opened this issue Jul 6, 2021 · 1 comment
Assignees
@poutsma
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.3.9

Comments

@poutsma
Copy link
Contributor

poutsma commented Jul 6, 2021

JettyClientHttpResponse checks for the presence of org.eclipse.jetty.websocket.server.JettyWebSocketServerContainer to determine whether it is running on Jetty 10, but that type is not necessarily present when using just the client libraries, without Jetty server.

We should improve JettyClientHttpResponse's Jetty 10 check.
@poutsma poutsma added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Jul 6, 2021
@poutsma poutsma added this to the 5.3.9 milestone Jul 6, 2021
@poutsma poutsma self-assigned this Jul 6, 2021
@poutsma poutsma closed this as completed in 94f56a2 Jul 6, 2021
poutsma added a commit that referenced this issue Jul 7, 2021
@poutsma
Various bug fixes in CronExpression
76b1c0f 
This commit makes various bug fixes in CronExpression and related files.

Closes gh-27136
@poutsma
Copy link
Contributor Author

poutsma commented Jul 7, 2021

Note that the previous commit linked to this issue by mistake. It should have pointed to #27117

@sync-by-unito sync-by-unito bot mentioned this issue Jul 14, 2021
Merged
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@poutsma @lxbzmy
Improve Jetty 10 check on client-side
3470309 
Before this commit, JettyClientHttpResponse checked for the presence of
a server-side class to determine whether it is running on Jetty 10.
Unfortunately, that class is not necessarily present when just using the
Jetty client.

This commit improves the Jetty 10 check, so that it also works when
the Jetty client is used without the server.

Closes spring-projectsgh-27136
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@poutsma @lxbzmy
Various bug fixes in CronExpression
7df2978 
This commit makes various bug fixes in CronExpression and related files.

Closes spring-projectsgh-27136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poutsma poutsma

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.9
Development

No branches or pull requests
1 participant
@poutsma