Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleMethodMetadataReadingVisitor.Source.toString() omits separator for method arguments #27095

Closed
sbrannen opened this issue Jun 24, 2021 · 0 comments
Closed

SimpleMethodMetadataReadingVisitor.Source.toString() omits separator for method arguments #27095

sbrannen opened this issue Jun 24, 2021 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.3.9

Comments

@sbrannen
Copy link
Member

The toString() implementation in SimpleMethodMetadataReadingVisitor.Source does not separate
method argument types with a comma.

For example, it generates org.example.MyClass.myMethod(java.lang.Stringjava.lang.Integer) instead of org.example.MyClass.myMethod(java.lang.String,java.lang.Integer).
@sbrannen sbrannen added type: bug A general bug in: core Issues in core modules (aop, beans, core, context, expression) labels Jun 24, 2021
@sbrannen sbrannen added this to the 5.3.9 milestone Jun 24, 2021
@sbrannen sbrannen self-assigned this Jun 24, 2021
sbrannen added a commit to sbrannen/spring-framework that referenced this issue Jun 24, 2021
@sbrannen
Fix bug in SimpleMethodMetadataReadingVisitor.Source.toString()
43901b2 
Prior to this commit, the toString() implementation did not separate
method argument types with a comma or any form of separator, leading
to results such as:

    org.example.MyClass.myMethod(java.lang.Stringjava.lang.Integer)

instead of:

    org.example.MyClass.myMethod(java.lang.String,java.lang.Integer)

Closes spring-projectsgh-27095
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Jun 24, 2021
Closed
@sync-by-unito sync-by-unito bot mentioned this issue Jul 14, 2021
Merged
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@sbrannen @lxbzmy
Fix bug in SimpleMethodMetadataReadingVisitor.Source.toString()
9e8c0ce 
Prior to this commit, the toString() implementation did not separate
method argument types with a comma or any form of separator, leading
to results such as:

    org.example.MyClass.myMethod(java.lang.Stringjava.lang.Integer)

instead of:

    org.example.MyClass.myMethod(java.lang.String,java.lang.Integer)

Closes spring-projectsgh-27095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.3.9
Development

No branches or pull requests
2 participants
@sbrannen @spring-projects-issues