HttpComponentsClientHttpConnector should close underlying resources #27032
Assignees
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
Milestone
Comments
bclozel
added
in: web
|
@bclozel I realized I never thanked you for the quick fix of this. It actually solved our problem back then; if we ever meet on a conference or something, I'll treat you to a beer or another tasty beverage of your choice ;-) |
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
Prior to this commit, the `HttpComponentsClientHttpConnector` implementation could accept or create a default `HttpClient` instance but not expose it as part of its API. This effectively prevents applications from properly closing the associated resources when disposing of the connector. This commit implements the `Closeable` interface on the connector to allow this use case. Closes spring-projectsgh-27032
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As seen in spring-projects/spring-boot#26214 (comment), the
HttpComponentsClientHttpConnectorcan be instantiated with a custom client instance or create a default one. The connector implementation doesn't provide access to the underlying client nor implements theCloseableinterface.We should ensure that the connector can close the resources it's using. This should not be done through the
WebClientinterface since client resources can be shared amongst clients or even with the server.In the case of the
HttpComponentsClientHttpConnectorin Spring Boot, it is created as a Spring bean and will be considered when components are shut down.The text was updated successfully, but these errors were encountered: