-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch back to parallel thread after WebSession id is generated #26958
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
Milestone
Comments
MaxBartkov
added a commit
to MaxBartkov/spring-framework
that referenced
this issue
May 21, 2021
Created merge request: #26965 |
rstoyanchev
added a commit
that referenced
this issue
May 24, 2021
Closing for now with the change to switch back to a parallel thread. That should address the specific side effects reported in spring-projects/spring-security#9200. We can explore a more optimal, longer term solution for 6.0, such as new methods on WebSession and ServerWebExchange or perhaps a non-blocking id generator if that's even feasible. |
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
It would be nice if there were a way to request the session without creating an instance of one, similar conceptually to
HttpServletRequest#getSession(false)
.Whenever the session is requested, say like so:
subscription will cause an
InMemoryWebSession
to be constructed. Since this is a blocking operation, it would be nice to avoid it when not needed.If instead an application could do:
then the predicate would not be invoked at all and construction of
InMemoryWebSession
would be avoided.The text was updated successfully, but these errors were encountered: