Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlightRecorderApplicationStartup is not thread safe #26941

Closed
philwebb opened this issue May 14, 2021 · 0 comments
Closed

FlightRecorderApplicationStartup is not thread safe #26941

philwebb opened this issue May 14, 2021 · 0 comments
Assignees
@bclozel
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Milestone
5.3.8

Comments

@philwebb
Copy link
Member

The ApplicationStartup class can be called from different threads when request scope beans are used. I think that FlightRecorderApplicationStartup could fail in such situations.

See spring-projects/spring-boot#25792 for a similar issue in Spring Boot's BufferingApplicationStartup
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label May 14, 2021
@bclozel bclozel self-assigned this May 17, 2021
@bclozel bclozel added this to the 5.3.8 milestone May 17, 2021
@bclozel bclozel added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels May 17, 2021
@jhoeller jhoeller added the in: core Issues in core modules (aop, beans, core, context, expression) label May 19, 2021
@bclozel bclozel closed this as completed in 7dbbf36 Jun 1, 2021
@sync-by-unito sync-by-unito bot mentioned this issue Jun 10, 2021
Closed
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
@bclozel @lxbzmy
Make FlightRecorderApplicationStartup thread safe
00688d7 
Prior to this commit, in some cases application context startup steps
could be created concurrently, which could cause issues with the current
implementation tracking the parent/child relationship between steps.

This commit ensures that the flight recorder implementation is using
thread safe collection implementations for that.

Fixes spring-projectsgh-26941
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: bug A general bug
Projects
None yet
Milestone
5.3.8
Development

No branches or pull requests
4 participants
@bclozel @philwebb @jhoeller @spring-projects-issues