Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WriteResultPublisher does not pass cancel signals #26642

Closed
rstoyanchev opened this issue Mar 4, 2021 · 0 comments
Closed

WriteResultPublisher does not pass cancel signals #26642

rstoyanchev opened this issue Mar 4, 2021 · 0 comments
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Mar 4, 2021

Typically server side response writing shouldn't see cancellation since ServletHttpHandlerAdapter doesn't do that. However it may occur for other reasons such as a WebFilter with a timeout operator on the outbound side. Even so in that case the timeout operator would also send an error signal downstream, which reaches ServletHttpHandlerAdapter and completes the AsyncContetx and that in turn cancels writing. Nevertheless it is a good idea to support cancellation and to cancel writing immediately.

This was uncovered while investigating #26434.

@rstoyanchev rstoyanchev added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Mar 4, 2021
@rstoyanchev rstoyanchev added this to the 5.3.5 milestone Mar 4, 2021
@rstoyanchev rstoyanchev self-assigned this Mar 4, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
lxbzmy pushed a commit to lxbzmy/spring-framework that referenced this issue Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant