-
Notifications
You must be signed in to change notification settings - Fork 38.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WriteResultPublisher does not pass cancel signals #26642
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
Milestone
Comments
rstoyanchev
added
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
labels
Mar 4, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this issue
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in: web
Issues in web modules (web, webmvc, webflux, websocket)
type: enhancement
A general enhancement
Typically server side response writing shouldn't see cancellation since
ServletHttpHandlerAdapter
doesn't do that. However it may occur for other reasons such as aWebFilter
with a timeout operator on the outbound side. Even so in that case the timeout operator would also send an error signal downstream, which reachesServletHttpHandlerAdapter
and completes theAsyncContetx
and that in turn cancels writing. Nevertheless it is a good idea to support cancellation and to cancel writing immediately.This was uncovered while investigating #26434.
The text was updated successfully, but these errors were encountered: