SimpleJdbcInsert (sporadically) does not insert all columns

[j8zdev]

Affects: Spring Framework 5.3.3

---

When using SimpleJdbcInsert without usingColumns(), it tries to determine the columns from database metadata. When there is any exception, a warning is logged, but otherwise the exception is ignored:

spring-framework/spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/GenericCallMetaDataProvider.java

Lines 415 to 419 in 9150980

	catch (SQLException ex) {
	if (logger.isWarnEnabled()) {
	logger.warn("Error while retrieving meta-data for procedure columns: " + ex);
	}
	}

This is fine as long as the exception occurs before any metadata could be read, because later this will cause an exception when generating the SQL string:

spring-framework/spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/TableMetaDataContext.java

Lines 305 to 306 in 9150980

	throw new InvalidDataAccessApiUsageException("Unable to locate columns for table '" +
	getTableName() + "' so an insert statement can't be generated");

However, when an SQLException occurs in columns.next() ...

spring-framework/spring-jdbc/src/main/java/org/springframework/jdbc/core/metadata/GenericCallMetaDataProvider.java

Line 390 in 9150980

while (columns.next()) {

... after the first column metadata has already been read and added to this.callParameterMetaData, it continues with an incomplete list of columns and only inserts these, ignoring any other columns.

We have experienced this problem in our system very sporadically, and it's especially dangerous, because SimpleJdbcInsert.execute() (as long as there are no NOT NULL constraints for the columns) returns seemingly successfully, so the transactions are committed with incomplete/corrupted data.

It seems like we can work around the problem by calling usingColumns() for all uses of SimpleJdbcInsert.

[sbrannen]

SimpleJdbcTemplate no longer exists in Spring Framework 5.3. So I assume you meant to refer to SimpleJdbcInsert. I've edited this issue's title and description accordingly.

In light of that, did you perhaps mean to provide a link to GenericTableMetaDataProvider instead of GenericCallMetaDataProvider?

Or are you using SimpleJdbcCall instead of SimpleJdbcInsert?

[sbrannen]

Or are you using SimpleJdbcCall instead of SimpleJdbcInsert?

In any case, it looks like GenericCallMetaDataProvider.processProcedureColumns(DatabaseMetaData, String, String, String) and GenericTableMetaDataProvider.processTableColumns(DatabaseMetaData, TableMetaData) have similar constructs that can result in partial metadata being recorded.

So I'll investigate both.

[j8zdev]

Sorry for the confusion. We're actually using SimpleJdbcInsert and I accidently linked to a similar but wrong line in GenericCallMetaDataProvider instead of GenericTableMetaDataProvider. But as you noticed, probably both are affected.

Thanks for investigating!

[sbrannen]

The fix has been merged into master (5.3.x) and 5.2.x.

Feel free to try it out in the latest 5.3.4 and 5.2.13 snapshots.