Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MergedAnnotationCollectors.toAnnotationSet() should not create intermediate ArrayList #26031

Closed
sbrannen opened this issue Nov 4, 2020 · 0 comments
Closed

MergedAnnotationCollectors.toAnnotationSet() should not create intermediate ArrayList #26031

sbrannen opened this issue Nov 4, 2020 · 0 comments
Assignees
@sbrannen
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.3.1

Comments

@sbrannen
Copy link
Member

sbrannen commented Nov 4, 2020

MergedAnnotationCollectors.toAnnotationSet() currently creates an intermediate ArrayList for storing the results prior to creating a LinkedHashSet in the finishing step. The creation of the intermediate list is unnecessary and can be avoided.
@sbrannen sbrannen added in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement labels Nov 4, 2020
@sbrannen sbrannen added this to the 5.3.1 milestone Nov 4, 2020
@sbrannen sbrannen self-assigned this Nov 4, 2020
sbrannen added a commit that referenced this issue Nov 4, 2020
@sbrannen
Use MergedAnnotationCollectors again in TestContextAnnotationUtils
b077e4c 
See gh-26031
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.2.x labels Nov 5, 2020
Closed
sbrannen added a commit that referenced this issue Nov 8, 2020
@sbrannen
Do not create intermediate list in MergedAnnotationCollectors.toAnnot…
da4e37d 
…ationSet()

Prior to this commit, MergedAnnotationCollectors.toAnnotationSet()
created an intermediate ArrayList for storing the results prior to
creating a LinkedHashSet in the finishing step.

Since the creation of the intermediate list is unnecessary, this commit
simplifies the implementation of toAnnotationSet() by using the
Collector.of() factory method that does not accept a `finisher` argument.
The resulting Collector internally uses a `castingIdentity()` function
as the `finisher`.

Closes gh-26031
@sync-by-unito sync-by-unito bot mentioned this issue Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.3.1
Development

No branches or pull requests
3 participants
@sbrannen @jhoeller @spring-projects-issues