Fix bug in calculation of maximum form part size

See gh-31343
spring-projects · Nov 6, 2023 · efb93ca · efb93ca
1 parent b3a6dba
commit efb93ca
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/...eb/src/main/java/org/springframework/http/codec/multipart/PartEventHttpMessageReader.java b/...eb/src/main/java/org/springframework/http/codec/multipart/PartEventHttpMessageReader.java
@@ -191,7 +191,14 @@ private boolean tooManyParts(AtomicInteger partCount) {
 	private Publisher<? extends PartEvent> createEvents(HttpHeaders headers, Flux<MultipartParser.BodyToken> bodyTokens) {
 		if (MultipartUtils.isFormField(headers)) {
 			Flux<DataBuffer> contents = bodyTokens.map(MultipartParser.BodyToken::buffer);
-			int maxSize = (int) Math.min(this.maxInMemorySize, this.maxPartSize);
+			int maxSize;
+			if (this.maxPartSize == -1) {
+				maxSize = this.maxInMemorySize;
+			}
+			else {
+				// maxInMemorySize is an int, so we can safely cast the long result of Math.min
+				maxSize = (int) Math.min(this.maxInMemorySize, this.maxPartSize);
+			}
 			return DataBufferUtils.join(contents, maxSize)
 					.map(content -> {
 						String value = content.toString(MultipartUtils.charset(headers));
@@ -222,8 +229,13 @@ private Publisher<? extends PartEvent> createEvents(HttpHeaders headers, Flux<Mu
 	}
 
 	private boolean tooLarge(AtomicLong partSize, DataBuffer buffer) {
-		long size = partSize.addAndGet(buffer.readableByteCount());
-		return this.maxPartSize > 0 && size > this.maxPartSize;
+		if (this.maxPartSize != -1) {
+			long size = partSize.addAndGet(buffer.readableByteCount());
+			return size > this.maxPartSize;
+		}
+		else {
+			return false;
+		}
 	}
 
 }
diff --git a/...c/test/java/org/springframework/http/codec/multipart/PartEventHttpMessageReaderTests.java b/...c/test/java/org/springframework/http/codec/multipart/PartEventHttpMessageReaderTests.java
@@ -257,7 +257,21 @@ void partSizeTooLarge() {
 				.assertNext(data(headersFormField("text2"), bodyText("b"), true))
 				.expectError(DataBufferLimitException.class)
 				.verify();
+	}
+
+	@Test
+	void formPartTooLarge() {
+		MockServerHttpRequest request = createRequest(
+				new ClassPathResource("simple.multipart", getClass()), "simple-boundary");
+
+		PartEventHttpMessageReader reader = new PartEventHttpMessageReader();
+		reader.setMaxInMemorySize(40);
+
+		Flux<PartEvent> result = reader.read(forClass(PartEvent.class), request, emptyMap());
 
+		StepVerifier.create(result)
+				.expectError(DataBufferLimitException.class)
+				.verify();
 	}
 
 	@Test