Skip to content

Commit

Permalink
Consistent ordering of overloaded operations
Browse files Browse the repository at this point in the history
  • Loading branch information
jhoeller committed Nov 15, 2023
1 parent eb1883b commit c373f49
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2021 the original author or authors.
* Copyright 2002-2023 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -527,26 +527,26 @@ int update(String sql, SqlParameterSource paramSource, KeyHolder generatedKeyHol
throws DataAccessException;

/**
* Executes a batch using the supplied SQL statement with the batch of supplied arguments.
* Execute a batch using the supplied SQL statement with the batch of supplied arguments.
* @param sql the SQL statement to execute
* @param batchValues the array of Maps containing the batch of arguments for the query
* @param batchArgs the array of {@link SqlParameterSource} containing the batch of
* arguments for the query
* @return an array containing the numbers of rows affected by each update in the batch
* (may also contain special JDBC-defined negative values for affected rows such as
* {@link java.sql.Statement#SUCCESS_NO_INFO}/{@link java.sql.Statement#EXECUTE_FAILED})
* @throws DataAccessException if there is any problem issuing the update
*/
int[] batchUpdate(String sql, Map<String, ?>[] batchValues);
int[] batchUpdate(String sql, SqlParameterSource[] batchArgs);

/**
* Execute a batch using the supplied SQL statement with the batch of supplied arguments.
* Executes a batch using the supplied SQL statement with the batch of supplied arguments.
* @param sql the SQL statement to execute
* @param batchArgs the array of {@link SqlParameterSource} containing the batch of
* arguments for the query
* @param batchValues the array of Maps containing the batch of arguments for the query
* @return an array containing the numbers of rows affected by each update in the batch
* (may also contain special JDBC-defined negative values for affected rows such as
* {@link java.sql.Statement#SUCCESS_NO_INFO}/{@link java.sql.Statement#EXECUTE_FAILED})
* @throws DataAccessException if there is any problem issuing the update
*/
int[] batchUpdate(String sql, SqlParameterSource[] batchArgs);
int[] batchUpdate(String sql, Map<String, ?>[] batchValues);

}
Original file line number Diff line number Diff line change
Expand Up @@ -359,11 +359,6 @@ public int update(
return getJdbcOperations().update(psc, generatedKeyHolder);
}

@Override
public int[] batchUpdate(String sql, Map<String, ?>[] batchValues) {
return batchUpdate(sql, SqlParameterSourceUtils.createBatch(batchValues));
}

@Override
public int[] batchUpdate(String sql, SqlParameterSource[] batchArgs) {
if (batchArgs.length == 0) {
Expand All @@ -388,6 +383,11 @@ public int getBatchSize() {
});
}

@Override
public int[] batchUpdate(String sql, Map<String, ?>[] batchValues) {
return batchUpdate(sql, SqlParameterSourceUtils.createBatch(batchValues));
}


/**
* Build a {@link PreparedStatementCreator} based on the given SQL and named parameters.
Expand Down

0 comments on commit c373f49

Please sign in to comment.