Skip to content

Commit

Permalink
Introduce DataFieldMaxValueIncrementer for MariaDB
Browse files Browse the repository at this point in the history
Closes gh-29379
  • Loading branch information
fmbenhassine authored and sbrannen committed Nov 1, 2022
1 parent c3fca0a commit 39f24f0
Show file tree
Hide file tree
Showing 2 changed files with 77 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
* Copyright 2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.jdbc.support.incrementer;

import javax.sql.DataSource;

/**
* {@link DataFieldMaxValueIncrementer} that retrieves the next value
* of a given MariaDB sequence.
*
* @author Mahmoud Ben Hassine
* @since 6.0.0
*/
public class MariaDBSequenceMaxValueIncrementer extends AbstractSequenceMaxValueIncrementer {

/**
* Default constructor for bean property style usage.
* @see #setDataSource
* @see #setIncrementerName
*/
public MariaDBSequenceMaxValueIncrementer() {
}

/**
* Convenience constructor.
* @param dataSource the DataSource to use
* @param incrementerName the name of the sequence to use
*/
public MariaDBSequenceMaxValueIncrementer(DataSource dataSource, String incrementerName) {
super(dataSource, incrementerName);
}

@Override
protected String getSequenceQuery() {
return "select next value for " + getIncrementerName();
}

}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2021 the original author or authors.
* Copyright 2002-2022 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -28,6 +28,7 @@
import org.springframework.jdbc.support.incrementer.DataFieldMaxValueIncrementer;
import org.springframework.jdbc.support.incrementer.HanaSequenceMaxValueIncrementer;
import org.springframework.jdbc.support.incrementer.HsqlMaxValueIncrementer;
import org.springframework.jdbc.support.incrementer.MariaDBSequenceMaxValueIncrementer;
import org.springframework.jdbc.support.incrementer.MySQLMaxValueIncrementer;
import org.springframework.jdbc.support.incrementer.OracleSequenceMaxValueIncrementer;
import org.springframework.jdbc.support.incrementer.PostgresSequenceMaxValueIncrementer;
Expand All @@ -43,6 +44,7 @@
*
* @author Juergen Hoeller
* @author Sam Brannen
* @author Mahmoud Ben Hassine
* @since 27.02.2004
*/
class DataFieldMaxValueIncrementerTests {
Expand Down Expand Up @@ -210,4 +212,26 @@ void postgresSequenceMaxValueIncrementer() throws SQLException {
verify(connection, times(2)).close();
}

@Test
void mariaDBSequenceMaxValueIncrementer() throws SQLException {
given(dataSource.getConnection()).willReturn(connection);
given(connection.createStatement()).willReturn(statement);
given(statement.executeQuery("select next value for myseq")).willReturn(resultSet);
given(resultSet.next()).willReturn(true);
given(resultSet.getLong(1)).willReturn(10L, 12L);

MariaDBSequenceMaxValueIncrementer incrementer = new MariaDBSequenceMaxValueIncrementer();
incrementer.setDataSource(dataSource);
incrementer.setIncrementerName("myseq");
incrementer.setPaddingLength(5);
incrementer.afterPropertiesSet();

assertThat(incrementer.nextStringValue()).isEqualTo("00010");
assertThat(incrementer.nextIntValue()).isEqualTo(12);

verify(resultSet, times(2)).close();
verify(statement, times(2)).close();
verify(connection, times(2)).close();
}

}

0 comments on commit 39f24f0

Please sign in to comment.