-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address #1089 issue. Change ZonedDateTime conversion mechanism #1119
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3eb8448
change ZonedDateTime conversion mechanism
mipo256 95d2593
DATAJDBC-1089 introduce custom int sql code mappings for some dialects
mipo256 5ae37da
DATAJDBC-1089 introduce custom int sql code mappings for some dialects
mipo256 b941921
Add built-in support for ZonedDateTime and OffsetDateTime in spring-d…
mipo256 293b7c1
Merge branch 'issue/DATAJDBC-1089' of https://github.com/Mikhail2048/…
mipo256 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,6 +32,7 @@ | |
import org.springframework.dao.OptimisticLockingFailureException; | ||
import org.springframework.data.domain.Pageable; | ||
import org.springframework.data.domain.Sort; | ||
import org.springframework.data.jdbc.repository.config.DialectResolver; | ||
import org.springframework.data.jdbc.support.JdbcUtil; | ||
import org.springframework.data.mapping.PersistentProperty; | ||
import org.springframework.data.mapping.PersistentPropertyAccessor; | ||
|
@@ -67,6 +68,8 @@ | |
* @author Myeonghyeon Lee | ||
* @author Yunyoung LEE | ||
* @author Radim Tlusty | ||
* @author Mikhail Polivakha | ||
* | ||
* @since 1.1 | ||
*/ | ||
public class DefaultDataAccessStrategy implements DataAccessStrategy { | ||
|
@@ -545,13 +548,26 @@ private IdentifierProcessing getIdentifierProcessing() { | |
private void addConvertedPropertyValue(SqlIdentifierParameterSource parameterSource, | ||
RelationalPersistentProperty property, @Nullable Object value, SqlIdentifier name) { | ||
|
||
addConvertedValue(parameterSource, value, name, converter.getColumnType(property), converter.getSqlType(property)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
final Class<?> javaColumnType = converter.getColumnType(property); | ||
addConvertedValue( | ||
parameterSource, | ||
value, | ||
name, | ||
javaColumnType, | ||
JdbcUtil.sqlTypeFor(javaColumnType, DialectResolver.getDialect(operations.getJdbcOperations())) | ||
); | ||
} | ||
|
||
private void addConvertedPropertyValue(SqlIdentifierParameterSource parameterSource, SqlIdentifier name, Object value, | ||
Class<?> javaType) { | ||
|
||
addConvertedValue(parameterSource, value, name, javaType, JdbcUtil.sqlTypeFor(javaType)); | ||
addConvertedValue( | ||
parameterSource, | ||
value, | ||
name, | ||
javaType, | ||
JdbcUtil.sqlTypeFor(javaType, DialectResolver.getDialect(operations.getJdbcOperations())) | ||
); | ||
} | ||
|
||
private void addConvertedValue(SqlIdentifierParameterSource parameterSource, @Nullable Object value, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can even remove this API, because parent method also perform the same
null
check. Also if we assume that any external client also use this API, then they will not notice anything, because in this case they will just call parentwriteValue
directly.