Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row to Entity Converter no longer used #1710

Closed
mlegenovic opened this issue Jan 3, 2024 · 1 comment
Closed

Row to Entity Converter no longer used #1710

mlegenovic opened this issue Jan 3, 2024 · 1 comment
Assignees
Labels
type: regression A regression from a previous release

Comments

@mlegenovic
Copy link

According to the documentation (Overriding Mapping with Explicit Converters) it should be possible to create custom mapper with a Row2Entity converter.

This worked quite well until version 3.2.0. As of this version, all Row ->Entity converters are ignored.

Is this a bug, or intentional, just the documentation not adapted?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 3, 2024
@mp911de mp911de added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 4, 2024
@mp911de
Copy link
Member

mp911de commented Jan 4, 2024

You are right, this is a regression. We migrated row reading into an intermediate type so that applications no longer need to consume uni-directional types. However, the migration isn't complete. We now use RowDocument to store all information instead of Row. We need to reinstate the Row-based approach.

Long-term, the mismatch between converters (Reading Row -> Entity, Writing Entity -> OutboundRow) will be resolved into Entity <-> RowDocument.

Until then, we have to fix this regression. Thanks for letting us know.

@mp911de mp911de added this to the 3.2.2 (2023.1.2) milestone Jan 4, 2024
@mp911de mp911de changed the title R2DBC custom mapper Row to Entity Converter no longer used Jan 4, 2024
@mp911de mp911de self-assigned this Jan 4, 2024
mp911de added a commit that referenced this issue Jan 4, 2024
We now consider converters for RowDocument. Additionally, we reinstated conversion from R2DBC's Row type into entities as that converter functionality got lost during the converter revision.

Closes #1710
@mp911de mp911de closed this as completed in 5647835 Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A regression from a previous release
Projects
None yet
Development

No branches or pull requests

3 participants