Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe SqlOrder should not be prefixed by table name. #1512

Closed
schauder opened this issue May 12, 2023 · 0 comments
Closed

Unsafe SqlOrder should not be prefixed by table name. #1512

schauder opened this issue May 12, 2023 · 0 comments
Assignees
@schauder
Labels
type: bug A general bug
Milestone
3.1.1 (2023.0.1)

Comments

@schauder
Copy link
Contributor

There shouldn't be a "tbl" prefix in this test a26557e#diff-b602e5e14bd6c315af58ccce89e85c5b50ed83c7767be468e631accf70e525beR433

The test was introduced while implementing #1507
schauder added a commit that referenced this issue May 12, 2023
@schauder
Do not prefix unsafe orer by expressions with table prefix.
86210b7 
Such expressions now get passed on unchanged.

This also deprecates org.springframework.data.r2dbc.query.QueryMapper.getMappedObject(Sort, RelationalPersistentEntity<?>).
It was only used in tests and translates an Order into another Order, which sounds wrong.

Closes #1512
@schauder schauder mentioned this issue May 12, 2023
Closed
@mp911de mp911de added the type: bug A general bug label May 15, 2023
@mp911de mp911de added this to the 3.1.1 (2023.0.1) milestone May 17, 2023
mp911de added a commit that referenced this issue May 17, 2023
@mp911de
Polishing.
bc70b0d 
Reformat code.

See #1512
Original pull request: #1513
mp911de pushed a commit that referenced this issue May 17, 2023
@schauder @mp911de
Do not prefix unsafe orer by expressions with table prefix.
e9459b8 
Such expressions now get passed on unchanged.

This also deprecates org.springframework.data.r2dbc.query.QueryMapper.getMappedObject(Sort, RelationalPersistentEntity<?>).
It was only used in tests and translates an Order into another Order, which sounds wrong.

Closes #1512
Original pull request: #1513
mp911de added a commit that referenced this issue May 17, 2023
@mp911de
Polishing.
51af65a 
Reformat code.

See #1512
Original pull request: #1513
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.1 (2023.0.1)
Development

Successfully merging a pull request may close this issue.

Do not prefix unsafe order by expressions with table prefix. spring-projects/spring-data-relational
2 participants
@schauder @mp911de