Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RedisConnectionFactory to Lifecycle beans #2503

Closed
mp911de opened this issue Feb 13, 2023 · 1 comment
Closed

Migrate RedisConnectionFactory to Lifecycle beans #2503

mp911de opened this issue Feb 13, 2023 · 1 comment
Assignees
Labels
type: enhancement A general enhancement

Comments

@mp911de
Copy link
Member

mp911de commented Feb 13, 2023

Based on spring-projects/spring-framework#29921, we could move our connection factories towards beans that implement the lifecycle. This would be especially useful to decouple afterPropertiesSet from the connection pool startup and dispose() where we dispose resources. With start() and stop() connection factories could start up pools and tear down as necessary without destroying the entire bean.

@mp911de mp911de added the type: enhancement A general enhancement label Feb 13, 2023
@jxblum
Copy link
Contributor

jxblum commented Feb 25, 2023

@mp911de - I'd need to think on this a bit more, but my first reaction when I read your comment is that this might also (would) be beneficial when using Spring Data Redis with CRaC (on GitHub) in conjunction with Spring Framework's (eventual/very-likely) support thereof.

@christophstrobl christophstrobl self-assigned this Jun 30, 2023
@mp911de mp911de changed the title Investigate migration of RedisConnectionFactory to Lifecycle beans Migrate RedisConnectionFactory to Lifecycle beans Jul 10, 2023
mp911de added a commit that referenced this issue Jul 10, 2023
Reorder factory fields according to immutable configuration, mutable configuration and connection factory state. Reorder methods and switch Jedis references to its current GitHub repository.

Refine assertions. Update documentation.

See: #2503
Original pull request: #2627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
3 participants