-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation ReadPreference #4503
Add annotation ReadPreference #4503
Conversation
Thank you @jorgerod for the PR we'll have a closer look asap. |
…itory' of https://github.com/jorgerod/spring-data-mongodb into feature/spring-projectsGH-2971-read-preference-at-repository
Thank you again @jorgerod for investing time into this feature and creating the PR, which looks very decent 👍 Things we'd need to consider as well are methods inherited from other repository interfaces like We do feel that fine grained control, like tags, are better suited for usage with the template API/custom repositories, where one has more control over the actual query and its dynamics. Therefore we think they should not surface on the repository level. |
Sorry for the waiting time but I've been quite busy lately. The changes you propose seem to me to be correct. I will follow your progress. Thank you |
…ethods. This commit reduces the API surface of the ReadPreference annotation leaving fine grained control such as Tags to the Template API. Next to supporting read preference for annotated queries we now also make sure to apply read preferences for annotated aggregation methods as well as predefined finder methods running queries. See: #2971 Original Pull Request: #4503
Tweak documentation wording. Refine constructor nullability rules. Fix javadoc references. Original Pull Request: #4503
Thank you again @jorgerod for your contribution! The changes have been merged to the main development line. |
Closes: #2971