Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend GridFsTemplate and its reactive variant to accept a provided GridFSBucket instance #4389

Closed
wants to merge 2 commits into from
Closed

Extend GridFsTemplate and its reactive variant to accept a provided GridFSBucket instance #4389

wants to merge 2 commits into from

Conversation

christophstrobl
Copy link
Member

This PR extends the GridFsTemplate implementations to accept a passed in a GridFSBucket to avoid recreating instances on every method call.

Closes: #1627

@christophstrobl
Prepare issue branch.
fb853b2
@christophstrobl
Extend Recative-/GridFsTemplate to accept provided a GridFSBucket ins…
a5bb0ce 
…tance.

Allow to pass in a GridFSBucket from outside to avoid recreating instances on every method call.
@christophstrobl christophstrobl changed the title Extend Recative-/GridFsTemplate to accept provided a GridFSBucket instance Extend Recative-/GridFsTemplate to accept a provided GridFSBucket instance May 17, 2023
@mp911de mp911de changed the title Extend Recative-/GridFsTemplate to accept a provided GridFSBucket instance Extend GridFsTemplate and its reactive variant to accept a provided GridFSBucket instance May 26, 2023
@mp911de mp911de added the type: enhancement A general enhancement label May 26, 2023
@mp911de mp911de added this to the 4.2 M1 (2023.1.0) milestone May 26, 2023
mp911de added a commit that referenced this pull request May 26, 2023
@mp911de
Polishing.
370b414 
Add assertions and missing Override annotations. Avoid recursive self-call on getClassLoader. Extend documentation.

See #1627
Original pull request: #4389
@mp911de mp911de closed this May 26, 2023
@mp911de mp911de deleted the issue/1627 branch May 26, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
4.2 M1 (2023.1.0)
Development

Successfully merging this pull request may close these issues.

Support provided GridFSBucket in GridFsTemplate
2 participants
@christophstrobl @mp911de