Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop AS token when creating JPQL count query using DISTINCT #3276

Closed
wants to merge 4 commits into from
Closed

Drop AS token when creating JPQL count query using DISTINCT #3276

wants to merge 4 commits into from

Conversation

christophstrobl
Copy link
Member

Fixes: #3269

@da-z
Copy link

da-z commented Mar 21, 2024

Hi. Will this be merged into main?

@christophstrobl christophstrobl requested a review from mp911de March 21, 2024 14:51
@da-z da-z mentioned this pull request Apr 9, 2024
Closed
@da-z
Copy link

da-z commented Apr 9, 2024

FYI, I've tested the fix and works fine. Could some please merge the fix into main? Thank you!

@christophstrobl christophstrobl marked this pull request as ready for review April 9, 2024 12:42
christophstrobl and others added 4 commits April 11, 2024 10:41
@mp911de mp911de changed the title Drop AS token when creating count for HqlQuery using DISTINCT. Drop AS token when creating JPQL count query using DISTINCT Apr 11, 2024
@mp911de mp911de changed the title Drop AS token when creating JPQL count query using DISTINCT Drop AS token when creating JPQL count query using DISTINCT Apr 11, 2024
@mp911de mp911de added the type: bug A general bug label Apr 11, 2024
@mp911de mp911de added this to the 3.1.11 (2023.0.11) milestone Apr 11, 2024
mp911de pushed a commit that referenced this pull request Apr 11, 2024
@christophstrobl @mp911de
Drop AS token when creating JPQL count query using DISTINCT.
5041f25 
Fixes: #3269
Original pull request: #3276
mp911de added a commit that referenced this pull request Apr 11, 2024
@mp911de
Polishing.
6ca7b79 
Apply select list rewriting to EQL and JPQL parsers as well.

See: #3269
Original pull request: #3276
mp911de pushed a commit that referenced this pull request Apr 11, 2024
@christophstrobl @mp911de
Drop AS token when creating JPQL count query using DISTINCT.
4fe7c2e 
Fixes: #3269
Original pull request: #3276
mp911de added a commit that referenced this pull request Apr 11, 2024
@mp911de
Polishing.
4e78786 
Apply select list rewriting to EQL and JPQL parsers as well.

See: #3269
Original pull request: #3276
mp911de pushed a commit that referenced this pull request Apr 11, 2024
@christophstrobl @mp911de
Drop AS token when creating JPQL count query using DISTINCT.
be9c0b5 
Fixes: #3269
Original pull request: #3276
mp911de added a commit that referenced this pull request Apr 11, 2024
@mp911de
Polishing.
2b66802 
Apply select list rewriting to EQL and JPQL parsers as well.

See: #3269
Original pull request: #3276
@mp911de mp911de closed this Apr 11, 2024
@mp911de mp911de deleted the issue/3269 branch April 11, 2024 08:59
@mp911de mp911de added type: regression A regression from a previous release and removed type: bug A general bug labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

Assignees

@mp911de mp911de

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.1.11 (2023.0.11)
Development

Successfully merging this pull request may close these issues.

Count query derivation from DISTINCT queries seems to be broken
3 participants
@christophstrobl @da-z @mp911de