-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply code polishing to leverage various Java 17 structures. #3134
Conversation
And I have a question. #3053 (comment) One example is the The implementation of that code includes the following code. if (selectStatement.getSelectBody()instanceof SetOperationList setOperationList) {
return applySortingToSetOperationList(setOperationList, sort);
} else if (!(selectStatement.getSelectBody() instanceof PlainSelect)) {
return queryString;
} If that's not what you intended, may I modify this to make it conform to the convention. |
Looks like the Thank you for your efforts @shin-mallang! |
Merged to |
I fixed methods that didn't use
instanceof pattern matching
to use it.I didn't apply it to the
equal
method because it seemed to generate without usinginstanceof pattern matching
.I also didn't apply it to the following part of
HibernateUtils
because it was ambiguous to apply, but if you have a good recommendation, I will apply it.