Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not use method ReactiveElasticsearchTemplate.execute because ReactiveElasticsearchTemplate.ClientCallback is not public #2814

Closed
kevinat opened this issue Dec 29, 2023 · 0 comments · Fixed by #2815
Closed

Can not use method ReactiveElasticsearchTemplate.execute because ReactiveElasticsearchTemplate.ClientCallback is not public #2814

kevinat opened this issue Dec 29, 2023 · 0 comments · Fixed by #2815
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Milestone
5.3 M1 (2024.0.0)

Comments

@kevinat
Copy link

kevinat commented Dec 29, 2023 

org.springframework.data.elasticsearch.client.elc.ReactiveElasticsearchTemplate#execute(ReactiveElasticsearchTemplate.ClientCallback<Publisher<T>> callback)

Using this method cause compile error:

'org.springframework.data.elasticsearch.client.elc.ReactiveElasticsearchTemplate.ClientCallback' is not public in 'org.springframework.data.elasticsearch.client.elc.ReactiveElasticsearchTemplate'. Cannot be accessed from outside package

I noticed we move ClientCallback interface from interface ReactiveElasticsearchOperations into class ReactiveElasticsearchTemplate, but it seems we forgot adding the public modifier for the inner interface in class.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 29, 2023
@kevinat kevinat changed the title Can not use method ReactiveElasticsearchTemplate.execute because ReactiveElasticsearchTemplate.Callback is not public Can not use method ReactiveElasticsearchTemplate.execute because ReactiveElasticsearchTemplate.ClientCallback is not public Dec 29, 2023
sothawo added a commit to sothawo/spring-data-elasticsearch that referenced this issue Dec 29, 2023
@sothawo
Make org.springframework.data.elasticsearch.client.elc.ReactiveElast…
abe3b17 
…icsearchTemplate.ClientCallback public

 Closes spring-projects#2814-reactive-client-callback
@sothawo sothawo mentioned this issue Dec 29, 2023
Merged
sothawo added a commit that referenced this issue Dec 29, 2023
@sothawo
Make org.springframework.data.elasticsearch.client.elc.ReactiveElast…
260dadd 
…icsearchTemplate.ClientCallback public.

Original Pull Request #2815
Closes #2814
@sothawo sothawo added the type: bug A general bug label Dec 29, 2023
@sothawo sothawo added this to the 5.3 M1 (2024.0.0) milestone Dec 29, 2023
sothawo added a commit that referenced this issue Dec 29, 2023
@sothawo
Make org.springframework.data.elasticsearch.client.elc.ReactiveElast…
e2e6b50 
…icsearchTemplate.ClientCallback public.

Original Pull Request #2815
Closes #2814

(cherry picked from commit 260dadd)
sothawo added a commit that referenced this issue Dec 29, 2023
@sothawo
Make org.springframework.data.elasticsearch.client.elc.ReactiveElast…
e6c125a 
…icsearchTemplate.ClientCallback public.

Original Pull Request #2815
Closes #2814

(cherry picked from commit 260dadd)
(cherry picked from commit e2e6b50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged type: bug A general bug
Projects
None yet
Milestone
5.3 M1 (2024.0.0)
3 participants
@sothawo @kevinat @spring-projects-issues