Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in BaseQueryBuilder.allowNoIndices option setter #2638

Closed
virtual-machinist opened this issue Jul 20, 2023 · 0 comments · Fixed by #2640
Closed

Typo in BaseQueryBuilder.allowNoIndices option setter #2638

virtual-machinist opened this issue Jul 20, 2023 · 0 comments · Fixed by #2640
Labels
type: enhancement A general enhancement
Milestone
5.2 M2 (2023.1.0)

Comments

@virtual-machinist
Copy link

The option setter for allowNoIndices in org.springframework.data.elasticsearch.core.query.BaseQueryBuilder is currently as follows:

	public SELF witAllowNoIndices(@Nullable Boolean allowNoIndices) {
		this.allowNoIndices = allowNoIndices;
		return self();
	}

should be perhaps withAllowNoIndices ?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 20, 2023
sothawo added a commit to sothawo/spring-data-elasticsearch that referenced this issue Jul 21, 2023
@sothawo
fix typos in method and docs.
bc41981 
Closes spring-projects#2638
@sothawo sothawo mentioned this issue Jul 21, 2023
Merged
sothawo added a commit that referenced this issue Jul 21, 2023
@sothawo
fix typos in method and docs.
0028d7d 
Original Pull Request #2640
Closes #2638
@sothawo sothawo added this to the 5.2 M2 (2023.1.0) milestone Jul 21, 2023
@sothawo sothawo added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M2 (2023.1.0)
Development

Successfully merging a pull request may close this issue.

fix typos in method and docs. sothawo/spring-data-elasticsearch
3 participants
@virtual-machinist @sothawo @spring-projects-issues