Fix MappingElasticsearchConverter.

Original Pull Request #2637 Closes #2627 (cherry picked from commit d9bb991)
spring-projects · Jul 18, 2023 · c045a8a · c045a8a
1 parent 11c87a1
commit c045a8a
Show file tree

Hide file tree

Showing 2 changed files with 57 additions and 7 deletions.
diff --git a/...va/org/springframework/data/elasticsearch/core/convert/MappingElasticsearchConverter.java b/...va/org/springframework/data/elasticsearch/core/convert/MappingElasticsearchConverter.java
@@ -919,7 +919,7 @@ private List<Object> writeCollectionInternal(Collection<?> source, @Nullable Typ
 
 				Class<?> elementType = element == null ? null : element.getClass();
 
-				if (elementType == null || conversions.isSimpleType(elementType)) {
+				if (elementType == null || isSimpleType(elementType)) {
 					collection.add(getPotentiallyConvertedSimpleWrite(element,
 							componentType != null ? componentType.getType() : Object.class));
 				} else if (element instanceof Collection || elementType.isArray()) {

diff --git a/...ringframework/data/elasticsearch/core/convert/MappingElasticsearchConverterUnitTests.java b/...ringframework/data/elasticsearch/core/convert/MappingElasticsearchConverterUnitTests.java
@@ -909,6 +909,55 @@ void shouldWriteNullValueIfConfigured() throws JSONException {
 		assertEquals(expected, document.toJson(), false);
 	}
 
+	@Test // #2627
+	@DisplayName("should write Map containing collection containing map")
+	void shouldWriteMapContainingCollectionContainingMap() throws JSONException {
+
+		class EntityWithMapCollectionMap {
+			Map<String, Object> map;
+		}
+		class InnerEntity {
+			String prop1;
+
+			String prop2;
+
+			public InnerEntity() {}
+
+			public InnerEntity(String prop1, String prop2) {
+				this.prop1 = prop1;
+				this.prop2 = prop2;
+			}
+
+		}
+
+		var entity = new EntityWithMapCollectionMap();
+		entity.map = Collections.singletonMap("collection",
+				Collections.singletonList(Collections.singletonMap("destination", new InnerEntity("prop1", "prop2"))));
+
+		var expected = """
+				{
+					"_class": "org.springframework.data.elasticsearch.core.convert.MappingElasticsearchConverterUnitTests$1EntityWithMapCollectionMap",
+					"map": {
+						"collection": [
+							{
+								"destination": {
+									"_class": "org.springframework.data.elasticsearch.core.convert.MappingElasticsearchConverterUnitTests$1InnerEntity",
+									"prop1": "prop1",
+									"prop2": "prop2"
+								}
+							}
+						]
+					}
+				}
+				""";
+
+		Document document = Document.create();
+
+		mappingElasticsearchConverter.write(entity, document);
+
+		assertEquals(expected, document.toJson(), false);
+	}
+
 	@Nested
 	class RangeTests {
 
@@ -1953,12 +2002,12 @@ void shouldWriteEntityWithDottedFieldName() throws JSONException {
 
 		@Language("JSON")
 		var expected = """
-				{
-					"_class": "org.springframework.data.elasticsearch.core.convert.MappingElasticsearchConverterUnitTests$FieldNameDotsEntity",
-					"id": "42",
-					"dotted.field": "dotted field"
-				}
-			""";
+					{
+						"_class": "org.springframework.data.elasticsearch.core.convert.MappingElasticsearchConverterUnitTests$FieldNameDotsEntity",
+						"id": "42",
+						"dotted.field": "dotted field"
+					}
+				""";
 		var entity = new FieldNameDotsEntity();
 		entity.setId("42");
 		entity.setDottedField("dotted field");
@@ -3192,6 +3241,7 @@ public void setMapToNotWriteWhenEmpty(@Nullable Map<String, String> mapToNotWrit
 			this.mapToNotWriteWhenEmpty = mapToNotWriteWhenEmpty;
 		}
 	}
+
 	static class FieldNameDotsEntity {
 		@Id
 		@Nullable private String id;