Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WindowIterator should emit items in order when scrolling backwards. #2857

Closed
christophstrobl opened this issue Jun 16, 2023 · 0 comments
Closed

WindowIterator should emit items in order when scrolling backwards. #2857

christophstrobl opened this issue Jun 16, 2023 · 0 comments
Assignees
@christophstrobl
Labels
type: bug A general bug
Milestone
3.1.1 (2023.0.1)

Comments

@christophstrobl
Copy link
Member

Scrolling backwards, WindowIterator should emit items in order eg. 10, 9, 8, 7,...
Currently backward scrolling is only considered on a Window basis, but items within the Window are ordered forward.
Using a limit of eg. 3 would therefore lead to something like 8, 9, 10, 5, 6, 7...
@christophstrobl christophstrobl added the type: bug A general bug label Jun 16, 2023
@christophstrobl christophstrobl self-assigned this Jun 16, 2023
@christophstrobl christophstrobl mentioned this issue Jun 16, 2023
Closed
@mp911de mp911de added this to the 3.1.1 (2023.0.1) milestone Jun 16, 2023
mp911de added a commit that referenced this issue Jun 16, 2023
@mp911de
Polishing.
6ca3170 
Use ReverseListIterator instead of Stream API to reduce overhead. ListIterator provides means to iterate backwards so we're wrapping the existing iterator.

See #2857.
Original pull request: #2858.
mp911de pushed a commit that referenced this issue Jun 16, 2023
@christophstrobl @mp911de
WindowIterator should emit items in order when scrolling backwards.
8671c00 
Closes #2857
Original pull request: #2858
mp911de added a commit that referenced this issue Jun 16, 2023
@mp911de
Polishing.
60877d7 
Use ReverseListIterator instead of Stream API to reduce overhead. ListIterator provides means to iterate backwards so we're wrapping the existing iterator.

See #2857.
Original pull request: #2858.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophstrobl christophstrobl

Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.1 (2023.0.1)
2 participants
@mp911de @christophstrobl