Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups in TypeInformation #2643

Open
3 tasks
odrotbohm opened this issue Jun 10, 2022 · 0 comments
Open
3 tasks

Cleanups in TypeInformation #2643

odrotbohm opened this issue Jun 10, 2022 · 0 comments
Assignees
@odrotbohm
Labels
type: enhancement A general enhancement

Comments

@odrotbohm
Copy link
Member

odrotbohm commented Jun 10, 2022 •
edited
Loading

  • Unify test cases in TypeInformationUnitTests (currently spread around in TypeDiscovererUnitTests and ClassTypeInformation).
  • Re-enable caching of raw ResolvableTypes in TypeDiscoverer once Issue with equals(…)/hashCode() for ResolvableType.forRawClass(…) spring-framework#28608 is resolved
  • Re-structure type hierarchy TI <-> ResolvableTI <-> CTI, GTI to simplify equals(…) / hashCode() arrangements by moving all methods except the ones overridden in CTI into RTI. Current implementations of those methods in TypeDiscoverer into GTI.
@odrotbohm odrotbohm self-assigned this Jun 10, 2022
odrotbohm added a commit that referenced this issue Jun 13, 2022
@odrotbohm
Additional refinements in TypeInformation reimplementation.
0fec82a 
Slight refinements in TypeDiscoverer.equals(…) / hashCode() that are still not completely valid, are different enough to work for differentiating use cases but not 100% efficient for cache cases. Captured outstanding work in #2643.

Reimplemented ….repository.query.Parameter.isDynamicProjectParameter(…) to bild on TypeInformation completely and properly unwrapp *all* wrapper types for type comparison.

Related ticket #2312.
odrotbohm added a commit that referenced this issue Jun 13, 2022
@odrotbohm
Additional refinements in TypeInformation reimplementation.
c08d207 
Slight refinements in TypeDiscoverer.equals(…) / hashCode() that are still not completely valid, are different enough to work for differentiating use cases but not 100% efficient for cache cases. Captured outstanding work in #2643.

Reimplemented ….repository.query.Parameter.isDynamicProjectParameter(…) to bild on TypeInformation completely and properly unwrapp *all* wrapper types for type comparison.

Related ticket #2312.
odrotbohm added a commit that referenced this issue Jun 13, 2022
@odrotbohm
Additional refinements in TypeInformation reimplementation.
2a1a8f3 
Slight refinements in TypeDiscoverer.equals(…) / hashCode() that are still not completely valid, are different enough to work for differentiating use cases but not 100% efficient for cache cases. Captured outstanding work in #2643.

Reimplemented ….repository.query.Parameter.isDynamicProjectParameter(…) to bild on TypeInformation completely and properly unwrapp *all* wrapper types for type comparison.

Related ticket #2312.
@mp911de mp911de added this to the 3.0 RC1 (2022.0.0) milestone Oct 4, 2022
@mp911de mp911de closed this as completed Oct 4, 2022
@mp911de mp911de reopened this Oct 4, 2022
@mp911de mp911de added status: blocked An issue that's blocked on an external project change type: enhancement A general enhancement labels Oct 4, 2022
@mp911de mp911de removed this from the 3.0 RC1 (2022.0.0) milestone Oct 4, 2022
@mp911de mp911de removed the status: blocked An issue that's blocked on an external project change label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odrotbohm @mp911de