-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assertion does not match its error message and comments for QueryOptions.readTimeout
method
#1494
Labels
type: bug
A general bug
Milestone
Comments
seungh0
pushed a commit
to seungh0/spring-data-cassandra
that referenced
this issue
Jun 12, 2024
If it is zero, the read timeout will be disabled for this statement Closes spring-projects#1494
seungh0
added a commit
to seungh0/spring-data-cassandra
that referenced
this issue
Jun 12, 2024
If it is zero, the read timeout will be disabled for this statement Closes spring-projects#1494
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Jun 12, 2024
4 tasks
seungh0
added a commit
to seungh0/spring-data-cassandra
that referenced
this issue
Jun 12, 2024
If it is zero, the read timeout will be disabled for this statement. Closes spring-projects#1494
Good catch, I think we might have more places like that one. I'm going to have a look during the merge. |
mp911de
added
type: bug
A general bug
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Jun 12, 2024
mp911de
changed the title
Assertion does not match its error message and comments for QueryOptions.ReadTimeout method
Assertion does not match its error message and comments for Jun 12, 2024
QueryOptions.readTimeout
method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there,
I noticed a discrepancy between the comments and error messages in the QueryOptions.ReadTimeout method and the actual behavior of the code.
I suggest allowing the code to accept 0 without raising an exception to handle disabling the timeout.
spring-data-cassandra/spring-data-cassandra/src/main/java/org/springframework/data/cassandra/core/cql/QueryOptions.java
Lines 540 to 556 in 100b267
I've also submitted a PR to address this. I would appreciate it if you could review it.
Thank you.
The text was updated successfully, but these errors were encountered: