Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of CassandraObservationConvention #1490

Closed
divyagangigunta123 opened this issue Apr 24, 2024 · 5 comments
Closed

Allow configuration of CassandraObservationConvention #1490

divyagangigunta123 opened this issue Apr 24, 2024 · 5 comments
Assignees
Labels
type: enhancement A general enhancement

Comments

@divyagangigunta123
Copy link

Hi Team,

I have integrated my spring boot application with cassandra observability. Have configured it and able to push low cardinality metrices to prometheus. But unable to push high cardinality keys to prometheus with the existing code base.

What all changes need to be done to push high cardinality keys as well ? or Can I convert high cardinality key to low cardinality key and push metrices to prometheus ?

Can you please allow wiring to CassandraObservationConvention interface ?

Regards,
Divya.G

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 24, 2024
@mp911de mp911de changed the title Convert db.statement from high cardinality to low cardinality in springboot cassandra observability Allow configuration of CassandraObservationConvention Apr 24, 2024
@mp911de
Copy link
Member

mp911de commented Apr 24, 2024

CassandraObservationConvention is deeply buried in CqlSessionObservationInterceptor and ObservableReactiveSession. Currently, there's no external access available to configure the convention.

We would need a configuration mechanism instead of passing on all the individual parts as method or constructor arguments.

@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 24, 2024
@divyagangigunta123
Copy link
Author

Can you please let me know how we can add configuration mechanism for assandraObservationConvention ?

@mp911de
Copy link
Member

mp911de commented Apr 24, 2024

Since all classes are package-private, there's nothing you could do except for duplicating our code into your codebase and applying the desired changes there.

@divyagangigunta123
Copy link
Author

Can you please let me know in which class only low cardinality keys are getting picked ? So, that will duplicate that codebase and modify accordingly for db.statement to be picked under low cardinality keys.

@divyagangigunta123
Copy link
Author

Can you please let me know which class need to be overridden and how to allow db.statement into low cardinality ? This will be helpful if you can please suggest on this

@mp911de mp911de self-assigned this Aug 21, 2024
@mp911de mp911de added this to the 4.3.4 (2024.0.4) milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants