Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to use structured logging with custom log configuration #43301

Closed
wants to merge 1 commit into from
Closed

Document how to use structured logging with custom log configuration #43301

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 27, 2024

I try to enable structured logging by configuring

logging:
  structured.format.console: ecs
  structured.format.file: ecs

It doesn't works because there is log4j2.xml in classpath, I think it's worthy to add warning to document.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 27, 2024
@quaff quaff marked this pull request as draft November 29, 2024 04:38
@quaff quaff changed the title Warn that "Custom Log Configuration" take precedence over "Structured Logging" Document caveat of combining "Structured Logging" and "Custom Log Configuration" Nov 29, 2024
@quaff quaff marked this pull request as ready for review November 29, 2024 05:16
@wilkinsona wilkinsona changed the title Document caveat of combining "Structured Logging" and "Custom Log Configuration" Document how to use structured logging with custom log configuration Nov 29, 2024
@mhalbritter mhalbritter added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 2, 2024
@mhalbritter mhalbritter added this to the 3.4.x milestone Dec 2, 2024
@mhalbritter mhalbritter self-assigned this Dec 5, 2024
mhalbritter pushed a commit that referenced this pull request Dec 5, 2024
@quaff @mhalbritter
Document how to use structured logging with custom log configuration
dd14158 
See gh-43301
mhalbritter added a commit that referenced this pull request Dec 5, 2024
@mhalbritter
Polish "Document how to use structured logging with custom log config…
2ff6dea 
…uration"

See gh-43301
@mhalbritter
Copy link
Contributor

Thanks @quaff !

@mhalbritter mhalbritter modified the milestones: 3.4.x, 3.4.1 Dec 5, 2024
@Netyyyy Netyyyy mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona left review comments

@mhalbritter mhalbritter mhalbritter left review comments

Assignees

@mhalbritter mhalbritter

Labels
type: documentation A documentation update
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@quaff @mhalbritter @wilkinsona @spring-projects-issues