Add JVM Checkpoint Restore documentation #37975
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdeleuze
force-pushed
the
crac-documentation
branch
from
54d189f to
8ca79c0
Compare
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: documentation
mhalbritter
pushed a commit
that referenced
this pull request
Oct 23, 2023
mhalbritter
added a commit
that referenced
this pull request
Oct 23, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal is to put CRaC documentation in the efficient deployment section, since we are providing an initial support and given the conciseness of the documentation, a dedicated top level section looks like not the best outcome from my point of view.
I have not added a link to the very useful https://github.com/sdeleuze/spring-boot-crac-demo repository since that's a personal one, and I was not sure it was ok for you. But if you are, I think it would add quite a lot of added value to include it (feel free to update my PR accordingly).
I did not add additional warnings on Spring Boot side related to being careful on not leaking sensitive data since Spring Framework documentation is already pretty clear about it, but if you want add a warning on Spring Boot side, that's on option.