Test in ExtractCommandTests does not write files to the project directory #37395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, this test would create files in the project directory. This can cause issues with Gradle caching and up-to-date checks. To address this, the value of the working directory is mocked to a temporary directory like all the other tests.
erichaagdev
changed the title
ExtractCommandTests writes files to the project directoryExtractCommandTests does not write files to the project directory
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: task
philwebb
changed the title
ExtractCommandTests does not write files to the project directory
wilkinsona
pushed a commit
that referenced
this pull request
Sep 22, 2023
Prior to this change, this test would create files in the project directory. This can cause issues with Gradle caching and up-to-date checks. To address this, the value of the working directory is mocked to a temporary directory like all the other tests. See gh-37395
|
Thanks very much, @erichaagdev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the
ExtractCommandTests#runWithJarFileThatWouldWriteEntriesOutsideDestinationFailstest to not write files to the project directory. This could cause issues with Gradle caching and up-to-date checks because some tasks depend on the project directory as an input (for example Checkstyle). See below:To address this, I mocked the working directory to a temporary directory like all the other tests in this class.