-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Jackson dependencies to spring-boot-dependencies #3727
Conversation
Add jackson-module-parameter-names, jackson-datatype-hibernate3, jackson-datatype-hibernate4, jackson-datatype-hibernate5, and jackson-datatype-jdk7.
</dependency> | ||
<dependency> | ||
<groupId>com.fasterxml.jackson.datatype</groupId> | ||
<artifactId>jackson-datatype-hibernate3</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Boot uses Hibernate 4, I'm not sure that it makes sense to add this
@wilkinsona I can see your point about hibernate3 module - I'll remove it. However, for the others, we're just basically allowing users to use them without manually specifying their versions so that the Jackson version remains consistent. We're not actually pulling in the dependencies or otherwise using (or even encouraging) their use - just making it easier to use if the user so desires. Therefore, I'm a bit unclear about what the concern is with adding them to the BOM. |
We take backwards compatibility seriously. Every new dependency in the bom is one whose versions we need to track and that we need to keep up-to-date. Generally speaking, Jackson's backwards compatibility is excellent. However, I don't know if they follow different rules for experimental modules hence me being wary of |
Hello, jackson-module-parameter-names author here. I don't expect many changes to the module in the future since the core functionality was done over a year ago when Java 8 came out. Code changes that happened later resolved around retrofitting the module to the changes in the Jackson API for introspectors and fixing/investigating several bugs. In fact, the module upholds the backwards compatibility for delegating creators, which annoyed some users so we added an option to override this behavior. |
Merged into master. Thanks for the PR, @candrews. |
Add jackson-module-parameter-names, jackson-datatype-hibernate3, jackson-datatype-hibernate4, jackson-datatype-hibernate5, and jackson-datatype-jdk7.
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.