Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Jackson dependencies to spring-boot-dependencies #3727

Closed
wants to merge 1 commit into from
Closed

Conversation

candrews
Copy link
Contributor

Add jackson-module-parameter-names, jackson-datatype-hibernate3, jackson-datatype-hibernate4, jackson-datatype-hibernate5, and jackson-datatype-jdk7.

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

Add jackson-module-parameter-names, jackson-datatype-hibernate3, jackson-datatype-hibernate4, jackson-datatype-hibernate5, and jackson-datatype-jdk7.
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-hibernate3</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that Boot uses Hibernate 4, I'm not sure that it makes sense to add this

@candrews
Copy link
Contributor Author

@wilkinsona I can see your point about hibernate3 module - I'll remove it.

However, for the others, we're just basically allowing users to use them without manually specifying their versions so that the Jackson version remains consistent. We're not actually pulling in the dependencies or otherwise using (or even encouraging) their use - just making it easier to use if the user so desires. Therefore, I'm a bit unclear about what the concern is with adding them to the BOM.

@wilkinsona
Copy link
Member

I'm a bit unclear about what the concern is with adding them to the BOM.

We take backwards compatibility seriously. Every new dependency in the bom is one whose versions we need to track and that we need to keep up-to-date. Generally speaking, Jackson's backwards compatibility is excellent. However, I don't know if they follow different rules for experimental modules hence me being wary of jackson-module-parameter-names.

@lpandzic
Copy link

Hello, jackson-module-parameter-names author here.

I don't expect many changes to the module in the future since the core functionality was done over a year ago when Java 8 came out. Code changes that happened later resolved around retrofitting the module to the changes in the Jackson API for introspectors and fixing/investigating several bugs.
All changes to the module are approved and merged by Jackson lead.
I hope that gives you some reassurance about backwards compatibility.

In fact, the module upholds the backwards compatibility for delegating creators, which annoyed some users so we added an option to override this behavior.

@wilkinsona
Copy link
Member

Thanks, @lpandzic. I'm convinced.

@candrews I'll take care of removing jackson-datatype-hibernate3 as part of merging this; no need for you to do anything.

@wilkinsona wilkinsona added the type: enhancement A general enhancement label Aug 12, 2015
@wilkinsona wilkinsona added this to the 1.3.0.RC1 milestone Aug 12, 2015
@wilkinsona wilkinsona self-assigned this Aug 12, 2015
@wilkinsona
Copy link
Member

Merged into master. Thanks for the PR, @candrews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants