Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging config URLs with query parameters are not detected as XML #37039

Closed
wants to merge 1 commit into from
Closed

Logging config URLs with query parameters are not detected as XML #37039

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Aug 21, 2023

Fix GH-37008

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 21, 2023
@quaff
Copy link
Contributor Author

quaff commented Aug 21, 2023

cc @philwebb

@scottfrederick scottfrederick added type: regression A regression from a previous release and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 21, 2023
@scottfrederick scottfrederick added this to the 3.0.x milestone Aug 21, 2023
@scottfrederick scottfrederick mentioned this pull request Aug 21, 2023
Closed
@snicoll snicoll self-assigned this Aug 22, 2023
@snicoll snicoll changed the title Detect logback config location as xml if path ends with .xml Logging config URLs with query parameters are not detected as XML Aug 22, 2023
@snicoll snicoll modified the milestones: 3.0.x, 3.0.10 Aug 22, 2023
@snicoll snicoll mentioned this pull request Aug 22, 2023
Closed
snicoll pushed a commit that referenced this pull request Aug 22, 2023
@quaff @snicoll
Detect logback config location as xml if path ends with .xml
c9cc1da 
See gh-37039
snicoll added a commit that referenced this pull request Aug 22, 2023
@snicoll
Polish "Detect logback config location as xml if path ends with .xml"
eed6e19 
See gh-37039
@snicoll snicoll closed this in bbc28c1 Aug 22, 2023
@philwebb
Copy link
Member

Thanks @quaff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.0.10
Development

Successfully merging this pull request may close these issues.

Logging config URLs with query parameters are not detected as XML
5 participants
@quaff @philwebb @scottfrederick @snicoll @spring-projects-issues