Align javadoc of AbstractFilterRegistrationBean#setDispatcherTypes #36965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
snicoll
added
type: documentation
snicoll
pushed a commit
that referenced
this pull request
Aug 14, 2023
snicoll
added a commit
that referenced
this pull request
Aug 14, 2023
|
@spa-abaudat good catch and thank you for making your first contribution to Spring Boot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Javadoc of
AbstractFilterRegistrationBean#setDispatcherTypesmistakenly claims that the dispatcher types will be deduced fromDynamicRegistrationBean.isAsyncSupported. This is not true since this commit, and is misleading as by defaultDynamicRegistrationBean.isAsyncSupportedis true, while the default dispatcher types for a filter that is not an instance ofOncePerRequestFiltercontains onlyREQUEST.