Artemis ConnectionFactory is not configured when CachingConnectionFactory is missing and enabled properties are false #36767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #17531 fixed it in ActiveMQ |
…is excluded Currently, if `CachingConnectionFactory` is excluded no ConnectionFactory is created.
eddumelendez
force-pushed
the
fix_artemis_autoconfiguration
branch
from
76c2271 to
a5b7460
Compare
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
added
type: bug
snicoll
changed the title
snicoll
changed the title
snicoll
pushed a commit
that referenced
this pull request
Aug 7, 2023
Previously, if spring-jms is not available and a non-pool connection factory is requested (the default), no `CachingConnectionFactory` is created. This commit makes sure to separate the two conditions, so that a connection factory can be obtained even if spring-jms is not on the classpath. See gh-36767
snicoll
added a commit
that referenced
this pull request
Aug 7, 2023
|
Good catch, thanks @eddumelendez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
CachingConnectionFactoryis excluded no ConnectionFactory iscreated.