Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tomcat warns about a missing +/- prefix when enabling multiple protocols through server.ssl.enabled-protocols #36572

Closed

Conversation

chicobento
Copy link
Contributor

@chicobento chicobento commented Jul 25, 2023

When configuring SSL with Tomcat, the following message is being logged in warning level by SSLHostConfig:

"The protocol [{0}] was added to the list of protocols on the SSLHostConfig named [{1}]. Check if a +/- prefix is missing."

This is because Tomcat's SSLHostConfig semantics for protocol string is:

        // List of protocol names, separated by ",", "+" or "-".
        // Semantics is adding ("+") or removing ("-") from left
        // to right, starting with an empty protocol set.
        // Tokens are individual protocol names or "all" for a
        // default set of supported protocols.
        // Separator "," is only kept for compatibility and has the
        // same semantics as "+", except that it warns about a potentially
        // missing "+" or "-".

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 25, 2023
@wilkinsona wilkinsona changed the title Fix tomcat ssl protocol warning log Tomcat warns about a missing +/- prefix when configuring server.ssl.enabled-protocols Jul 25, 2023
@wilkinsona wilkinsona added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 25, 2023
@wilkinsona wilkinsona changed the title Tomcat warns about a missing +/- prefix when configuring server.ssl.enabled-protocols Tomcat warns about a missing +/- prefix when enabling multiple protocols through server.ssl.enabled-protocols Jul 25, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Jul 25, 2023
@mhalbritter mhalbritter self-assigned this Jul 26, 2023
mhalbritter pushed a commit that referenced this pull request Jul 26, 2023
@mhalbritter
Copy link
Contributor

Thank you very much and congratulations on your first contribution 🎉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants