Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that server.forward-headers-strategy property defaults to native when running on Kubernetes #36564

Closed

Conversation

MahatmaFatalError
Copy link
Contributor

@MahatmaFatalError MahatmaFatalError commented Jul 25, 2023

I found that my app on k8s has server.forward-headers-strategy NATIVE but the docs do not state so.
Hence I propose this quick fix.
Please confirm, I could not find the particular code line to control that behavior.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 25, 2023
@wilkinsona wilkinsona added type: documentation A documentation update and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 25, 2023
@wilkinsona wilkinsona added this to the 2.7.x milestone Jul 25, 2023
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the update, @MahatmaFatalError. Can you please remove the draft status from the PR?

@wilkinsona wilkinsona changed the title Docs: server.forward-headers-strategy property defaults to NATIVE also for k8s Document that server.forward-headers-strategy property defaults to native when running on Kubernetes Jul 25, 2023
@MahatmaFatalError MahatmaFatalError marked this pull request as ready for review July 25, 2023 17:37
@mhalbritter mhalbritter self-assigned this Jul 26, 2023
@mhalbritter
Copy link
Contributor

Thank you very much and congratulations on your first contribution 🎉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants