Support for Base64 encoded p12 keystore using the ssl bundle configuration #35890
Conversation
|
@erwinc1 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@erwinc1 Thank you for signing the Contributor License Agreement! |
| URL url = ResourceUtils.getURL(location); | ||
| try (InputStream stream = url.openStream()) { | ||
| store.load(stream, password); | ||
| if (isBase64(location.getBytes())) { |
There was a problem hiding this comment.
Maybe instead of doing the decode twice, where you test first if you can decode it, you could do the else part in the catch block?
scottfrederick
added
type: bug
philwebb
added
for: team-meeting
philwebb
added
type: enhancement
|
@erwinc1 Thanks very much for the suggestion. We agree this is something that we'd like Spring Boot to support. However, we'd like to take a different approach to the problem that would allow us to apply the same pattern to other places where file resources are currently supported in configuration properties instead of just making your suggested change to SSL bundle JKS keystores. I've opened #36033 to capture this. |
scottfrederick
added
status: superseded
I've added support for Base64 encoded p12 formatted keystores. This is my backing StackOverflow question