Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The error message is unhelpful when spring.rabbitmq.host is configured with a comma-separated value #35684

Closed
wants to merge 1 commit into from
Closed

The error message is unhelpful when spring.rabbitmq.host is configured with a comma-separated value #35684

wants to merge 1 commit into from

Conversation

rafaelrc7
Copy link
Contributor

As discussed on issue #35628, at some point the host property accepted multiple comma-separated hosts. However, this was not intended, and for better clarification, it was decided to implement a clearer error message for this situation.

This PR adds an extra check in org.springframework.boot.autoconfigure.amqp.RabbitProperties#determineAddresses for commas in the host property, throwing an InvalidConfigurationPropertyValueException if any is found.

@rafaelrc7
Implement validity check to spring.rabbitmq.host config property
fdfb17f 
As discussed on issue spring-projects#35628, at some point the host property accepted multiple comma-separated hosts. However, this was not intended, and for better clarification, it was decided to implement a clearer error message for this situation.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 31, 2023
@mhalbritter mhalbritter added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 31, 2023
@mhalbritter mhalbritter added this to the 3.1.x milestone May 31, 2023
@mhalbritter mhalbritter mentioned this pull request May 31, 2023
Closed
@mhalbritter mhalbritter changed the title Implement validity check to spring.rabbitmq.host config property Check whether spring.rabbitmq.host config property is valid May 31, 2023
@wilkinsona wilkinsona changed the title Check whether spring.rabbitmq.host config property is valid The error message is unhelpful when spring.rabbitmq.host is configured with a comma-separated value Jun 1, 2023
@mhalbritter mhalbritter self-assigned this Jun 5, 2023
@mhalbritter
Copy link
Contributor

Thank you very much and congratulations on your first contribution 🎉!

@mhalbritter mhalbritter modified the milestones: 3.1.x, 3.1.1 Jun 5, 2023
mhalbritter pushed a commit that referenced this pull request Jun 5, 2023
@rafaelrc7 @mhalbritter
Implement validity check to spring.rabbitmq.host config property
ed47e09 
As discussed on issue #35628, at some point the host property accepted
multiple comma-separated hosts. However, this was not intended, and for
better clarification, it was decided to implement a clearer error
message for this situation.

See gh-35684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelrc7 @mhalbritter @spring-projects-issues