Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of build-image and build-image-no-fork Maven plugin goals is inconsistent #35609

Closed
wants to merge 4 commits into from
Closed

Description of build-image and build-image-no-fork Maven plugin goals is inconsistent #35609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40f6421
Improved description of build-image-no-fork Maven plugin goal
ThomasKasene May 23, 2023
2e1f46d
Improved description of build-image Maven plugin goal
ThomasKasene May 23, 2023
afd5c61
Ran formatting
ThomasKasene May 23, 2023
f3e9b5b
Replaced mojo with goal
ThomasKasene May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ng-boot-maven-plugin/src/main/java/org/springframework/boot/maven/BuildImageForkMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@
import org.apache.maven.plugins.annotations.ResolutionScope;

/**
* {@link BuildImageMojo implementation} that forks the lifecycle to make sure that
* {@code package} ran. This goal is suitable for command-line invocation. If you need to
* configure a mojo {@code execution} in your build, use {@link BuildImageNoForkMojo}
* instead.
* Package an application into an OCI image using a buildpack, forking the lifecycle to
* make sure that {@code package} ran. This goal is suitable for command-line invocation.
* If you need to configure a goal {@code execution} in your build, use
* {@code build-image-no-fork} instead.
*
* @author Stephane Nicoll
* @since 3.0.0
Expand Down
8 changes: 4 additions & 4 deletions ...-boot-maven-plugin/src/main/java/org/springframework/boot/maven/BuildImageNoForkMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
import org.apache.maven.plugins.annotations.ResolutionScope;

/**
* {@link BuildImageMojo implementation} that does not fork the lifecycle to make sure
* that {@code package} ran. This goal should be used when configuring a mojo
* {@code execution} in your build. To invoke the goal on the command-line, use
* {@link BuildImageForkMojo} instead.
* Package an application into an OCI image using a buildpack, but without forking the
* lifecycle to make sure that {@code package} ran. This goal should be used when
* configuring a goal {@code execution} in your build. To invoke the goal on the
* command-line, use {@code build-image} instead.
*
* @author Stephane Nicoll
* @since 3.0.0
Expand Down